Merge pull request #1915 from wazuh/enh/1911-Ensure_boolean_condition_evaluations__from_community_PR

Ensure boolean condition evaluations from community pr #1897

CHANGELOG.md

@@ -9,7 +9,7 @@ All notable changes to this project will be documented in this file.
 
 ### Changed
 
-- None
+- Ensure boolean condition evaluations - from community PR #1897 ([#1911](https://github.com/wazuh/wazuh-ansible/pull/1911))
 
 ### Fixed
 

roles/wazuh/ansible-wazuh-manager/tasks/main.yml

@@ -10,7 +10,7 @@
           - tar
         state: present
       register: package_status
-      until: "package_status is not failed"  
+      until: "package_status is not failed"
       retries: 10
       delay: 10
 
@@ -20,7 +20,7 @@
         state: present
       when: ansible_distribution != "Amazon" and ansible_distribution_version != "2023"
       register: package_status
-      until: "package_status is not failed"  
+      until: "package_status is not failed"
       retries: 10
       delay: 10
 
@@ -30,7 +30,7 @@
         state: present
       when: ansible_distribution == "Amazon" and ansible_distribution_version == "2023"
       register: package_status
-      until: "package_status is not failed"  
+      until: "package_status is not failed"
       retries: 10
       delay: 10
 
@@ -73,7 +73,7 @@
   tags:
     - init
     - config
-  
+
 - name: Install expect
   package:
     name: expect
@@ -242,7 +242,7 @@
   notify: restart wazuh-manager
   when:
     - csyslog_enabled.stdout == '0' or "skipped" in csyslog_enabled.stdout
-    - syslog_output is defined and syslog_output
+    - syslog_output is defined and (syslog_output | bool)
   tags:
     - config
 

roles/wazuh/wazuh-indexer/tasks/main.yml

@@ -108,7 +108,8 @@
       delay: 5
       tags: debug
       when:
-        - hostvars[inventory_hostname]['private_ip'] is not defined or (hostvars[inventory_hostname]['private_ip'] | string | length) == 0
+        - hostvars[inventory_hostname]['private_ip'] is not defined or
+          (hostvars[inventory_hostname]['private_ip'] | length) == 0
 
     - name: Wait for Wazuh indexer API (Private IP)
       uri:
@@ -127,7 +128,8 @@
       delay: 5
       tags: debug
       when:
-        - hostvars[inventory_hostname]['private_ip'] is defined and (hostvars[inventory_hostname]['private_ip'] | string | length) > 0
+        - hostvars[inventory_hostname]['private_ip'] is defined and
+          (hostvars[inventory_hostname]['private_ip'] | length) > 0
 
     - import_tasks: "RMRedHat.yml"
       when: ansible_os_family == "RedHat"

roles/wazuh/wazuh-indexer/tasks/security_actions.yml

@@ -114,6 +114,5 @@
   register: result
   until: result.status in [200,201,401]
   when:
-    - indexer_create_custom_user | default(false) | bool
     - indexer_custom_user | default('') | trim | length > 0
     - inventory_hostname == ansible_play_hosts[0]