improved the tasks of filebeat module installation and fixed idempotence errors

Pipfile

@@ -14,6 +14,7 @@ molecule = "*"
 python_version = "2.7"
 
 [scripts]
+clean = "molecule destroy"
 test ="molecule test"
 agent ="molecule test -s wazuh-agent"
 elasticsearch ="molecule test -s elasticsearch"

molecule/filebeat/molecule.yml

@@ -9,8 +9,8 @@ lint:
     config-data:
       ignore: .virtualenv
 platforms:
-  - name: trusty
+ # - name: trusty
-    image: ubuntu:trusty
+ #   image: ubuntu:trusty
  # - name: bionic
  #   image: solita/ubuntu-systemd:bionic
  #   command: /sbin/init
@@ -25,9 +25,9 @@ platforms:
  #  command: /sbin/init
  #  volumes:
  #    - /sys/fs/cgroup:/sys/fs/cgroup:ro
- #- name: centos7
+ - name: centos7
- #  image: milcom/centos7-systemd
+   image: milcom/centos7-systemd
- #  privileged: true
+   privileged: true
 provisioner:
   name: ansible
   playbooks:

roles/wazuh/ansible-filebeat/tasks/main.yml

@@ -88,19 +88,39 @@
     - filebeat_xpack_security
   tags: xpack-security
 
+- name: Checking if Filebeat Module folder file exists
+  stat:
+    path: "{{ filebeat_module_folder }}"
+  register: filebeat_module_folder
+
 - name: Download Filebeat module package
   get_url:
     url: https://packages.wazuh.com/3.x/filebeat/{{ filebeat_module_package_name }}
     dest: "{{ filebeat_module_package_path }}"
+  when: not filebeat_module_folder.stat.exists
 
-- name: Unpakcaging Filebeat module package
+- name: Unpakcing Filebeat module package
   unarchive:
     src: "{{ filebeat_module_package_path }}/{{ filebeat_module_package_name }}"
     dest: "{{ filebeat_module_destination }}"
     remote_src: yes
+  when: not filebeat_module_folder.stat.exists
 
 - name: Setting 0755 permission for Filebeat module folder
   file: dest={{ filebeat_module_folder }} mode=u=rwX,g=rwX,o=rwX recurse=yes
+  when: not filebeat_module_folder.stat.exists
+
+- name: Checking if Filebeat Module package file exists
+  stat:
+    path: "{{ filebeat_module_package_path }}/{{ filebeat_module_package_name }}"
+  register: filebeat_module_package
+  when: filebeat_module_package is not defined
+
+- name: Delete Filebeat module package file
+  file:
+    state: absent
+    path: "{{ filebeat_module_package_path }}/{{ filebeat_module_package_name }}"
+  when: filebeat_module_package.stat.exists
 
 - import_tasks: config.yml
   when: filebeat_create_config